fix(themes): increase default retries in jobPollStatus #276
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-almeida
approved these changes
Dec 18, 2024
Fredx87
reviewed
Dec 18, 2024
There was a problem hiding this comment.
I think we should use conventional commit for commit messages, otherwise this fix will not be written in the changelog. The title of the PR uses feat(pollJobStatus), but not the commit message.
I would argue that this is a fix and not a feature, and the scope is themes rather than pollJobStatus
BrunoBFerreira
force-pushed
the
brunobferreira/GG-4014/increase-timeout-on-theme-import
branch
from
98cd3d6 to
b381fe9
Compare
BrunoBFerreira
changed the title
|
I believe I have addressed both comments. Could you take another look @Fredx87 and @luis-almeida ? |
luis-almeida
approved these changes
Dec 18, 2024
Fredx87
approved these changes
Dec 18, 2024
luis-almeida
deleted the
brunobferreira/GG-4014/increase-timeout-on-theme-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of our customers is using ZCLI to automate their CI/CD and import themes. However, sometimes they are getting an error from the import command due to time out, but the theme is actually imported.
This happens because the
pollJobStatusis using all the retries to fetch the job status but the job ends up finishing after all the checks are used.To prevent this from happening and in an attempt to make this command more stable, we are increasing the default value for retries, so that we continue polling for the status, giving more time for the job to update its status.
b381fe9fix(themes): increase default retries in jobPollStatusDetail
Checklist